Added SDL_HINT_APP_NAME#124
Open
upcz wants to merge 1 commit into
Open
Conversation
kblaschke
requested changes
Jun 1, 2026
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Please amend your commit to remove the comment regarding the ::name() return value, then I can merge the PR.
| const char* SDLRenderingWindow::name() const | ||
| { | ||
| return "SDL2 Rendering Window"; | ||
| return "SDL2 Rendering Window"; // Why..? This isn't used anywhere |
Member
There was a problem hiding this comment.
Because this method must be implemented, please read the docs:
https://docs.pocoproject.org/current/Poco.Util.Subsystem.html#36011
Please remove this comment, then I can merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.